create separate timer for redraw requests #8023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalkuthe
added
C-bug
|
(Added to next because this is a regression) |
Co-authored-by: Michael Davis <[email protected]>
the-mikedavis
approved these changes
Aug 21, 2023
dgkf
pushed a commit
to dgkf/helix
that referenced
this pull request
Jan 30, 2024
* create separate timer for redraw requests * Update helix-view/src/editor.rs Co-authored-by: Michael Davis <[email protected]> --------- Co-authored-by: Michael Davis <[email protected]>
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
* create separate timer for redraw requests * Update helix-view/src/editor.rs Co-authored-by: Michael Davis <[email protected]> --------- Co-authored-by: Michael Davis <[email protected]>
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
* create separate timer for redraw requests * Update helix-view/src/editor.rs Co-authored-by: Michael Davis <[email protected]> --------- Co-authored-by: Michael Davis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The redraw handle was using the idle timeout to denounce redraw requests so far. I will openly admit that I didn't quite appreciate the importance of the idle timeout back when I wrote the diff gutter PR (as I was still new to the codebase). It didn't really matter back then because the diff gutter timing out is a very rare occurrence but with #7538 the redraw handle is now triggered quite commonly which essentially makes the idle-timeout setting useless.
This PR fixes that by simply adding a separate timer for the redraw handle. In the long term we may move away from using the idle-timeout for debouncing data model update (#8021) at which point it would be fine to switch back to the idle timeout. Until all of that (substantial) work is finished I think its a good idea to fix this in the meantime (especially looking toward the next release).